linux-kernel - Re: [patch] smack: opt_dentry is never null in in smack_d

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 2 Jun 2010 11:56:36 +1000 (EST)
From:	James Morris <jmorris@...ei.org>
To:	Dan Carpenter <error27@...il.com>
cc:	Casey Schaufler <casey@...aufler-ca.com>,
	"David P. Quigley" <dpquigl@...ho.nsa.gov>,
	David Howells <dhowells@...hat.com>,
	Serge Hallyn <serue@...ibm.com>,
	linux-security-module@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [patch] smack: opt_dentry is never null in in
 smack_d_instantiate()

On Tue, 1 Jun 2010, Dan Carpenter wrote:

> This patch removes some unneeded code for if opt_dentry is null because
> that can never happen.
> 
> The function dereferences "opt_dentry" earlier when it checks 
> "if (opt_dentry->d_parent == opt_dentry) {".  That code was added in
> 2008.
> 
> This function called from security_d_instantiate().  I checked all the 
> places which call security_d_instantiate() and dentry is always non-null.
> I also checked the selinux version of this hook and there is a comment
> which says that dentry should be non-null if called from 
> d_instantiate().
> 
> Signed-off-by: Dan Carpenter <error27@...il.com>


Applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6#next

-- 
James Morris
<jmorris@...ei.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/