linux-kernel - Re: [Uclinux-dist-devel] [PATCH v2] regulator: new drivers for AD5398 and AD5821

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100602094733.GA13983@rakim.wolfsonmicro.main>
Date:	Wed, 2 Jun 2010 10:47:33 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Mike Frysinger <vapier.adi@...il.com>
Cc:	sonic zhang <sonic.adi@...il.com>,
	Liam Girdwood <lrg@...mlogic.co.uk>,
	uclinux-dist-devel <uclinux-dist-devel@...ckfin.uclinux.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [Uclinux-dist-devel] [PATCH v2] regulator: new drivers for
 AD5398 and AD5821

On Wed, Jun 02, 2010 at 05:02:58AM -0400, Mike Frysinger wrote:

> > +       dev_dbg(&client->dev, "%s regulator driver loaded\n", id->name);

> does the regulator core take care of displaying a notice ?  if not,
> i'd make this dev_info().  also, this should be "registered", not
> "loaded".

A message will be displayed if the device actually has any constraints
(and is therefore in use) so if it makes any difference to the system
there will be some chat.

> > +MODULE_DESCRIPTION("AD5398 and AD5821 current regulator driver");
> > +MODULE_AUTHOR("Sonic Zhang");
> > +MODULE_LICENSE("GPL");

> should there be a MODULE_ALIAS() ?

Possibly, though it's unlikely that actual systems will ever build a
regulator they're using as a module.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/