linux-kernel - Re: [PATCH 2/5] x86: Split __show

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <874ohl21ps.wl%vmayatsk@redhat.com>
Date:	Wed, 02 Jun 2010 12:00:47 +0200
From:	Vitaly Mayatskikh <v.mayatskih@...il.com>
To:	Pekka Enberg <penberg@...helsinki.fi>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, Vivek Goyal <vgoyal@...hat.com>,
	Randy Dunlap <rdunlap@...otime.net>
Subject: Re: [PATCH 2/5] x86: Split __show_regs()

At Wed, 2 Jun 2010 12:50:03 +0300, Pekka Enberg wrote:
> 
> On Wed, Jun 2, 2010 at 10:39 AM, Vitaly Mayatskikh
> <v.mayatskih@...il.com> wrote:
> > __show_regs dumps content of pt_regs and does other things beside
> > it. This patch moves pt_regs dumping part into separate function:
> > __show_main_regs.
> >
> > Signed-off-by: Vitaly Mayatskikh <v.mayatskih@...il.com>
> 
> [snip]
> 
> > +void __show_regs(struct pt_regs *regs, int all)
> > +{
> > +       unsigned long cr0 = 0L, cr2 = 0L, cr3 = 0L, cr4 = 0L;
> > +       unsigned long d0, d1, d2, d3, d6, d7;
> > +
> > +
> 
> Nitpick: extra newline here.

Thanks for catching!

-- 
wbr, Vitaly
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/