linux-kernel - Re: [PATCH] ext3: fix non-update ctime when changing the file's permission by setfacl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100602121442.GA28648@atrey.karlin.mff.cuni.cz>
Date:	Wed, 2 Jun 2010 14:14:42 +0200
From:	Jan Kara <jack@...e.cz>
To:	Miao Xie <miaox@...fujitsu.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>, adilger@....com,
	Linux-Ext4 <linux-ext4@...r.kernel.org>,
	Linux-Kernel <linux-kernel@...r.kernel.org>, agruen@...e.de
Subject: Re: [PATCH] ext3: fix non-update ctime when changing the file's
	permission by setfacl

> ext3 didn't update the ctime of the file when its permission was changed.
> 
> Steps to reproduce:
>  # touch aaa
>  # stat -c %Z aaa
>  1275289822
>  # setfacl -m  'u::x,g::x,o::x' aaa
>  # stat -c %Z aaa
>  1275289822				<- unchanged
> 
> But, according to the spec of the ctime, ext3 must update it.
  Yeah, good spotting. Thanks. Looking at various code, the bug was probably
cut-n-pasted to all the filesystems (except XFS)... Sigh. It would be nice to
handle this somehow generically in VFS but currently I don't see a way. So
probably I'll take filesystems one by one and fix them.

								Honza
> 
> Signed-off-by: Miao Xie <miaox@...fujitsu.com>
> ---
>  fs/ext3/acl.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/fs/ext3/acl.c b/fs/ext3/acl.c
> index 01552ab..8a11fe2 100644
> --- a/fs/ext3/acl.c
> +++ b/fs/ext3/acl.c
> @@ -205,6 +205,7 @@ ext3_set_acl(handle_t *handle, struct inode *inode, int type,
>  					return error;
>  				else {
>  					inode->i_mode = mode;
> +					inode->i_ctime = CURRENT_TIME_SEC;
>  					ext3_mark_inode_dirty(handle, inode);
>  					if (error == 0)
>  						acl = NULL;
> -- 
> 1.6.5.2
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
-- 
Jan Kara <jack@...e.cz>
SuSE CR Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/