linux-kernel - Re: linux-next: build failure after merge of the rr tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201006021415.17205.rusty@rustcorp.com.au>
Date:	Wed, 2 Jun 2010 14:15:16 +0930
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Stephen Rothwell <sfr@...b.auug.org.au>
Cc:	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Jason Wessel <jason.wessel@...driver.com>,
	Martin Hicks <mort@....com>
Subject: Re: linux-next: build failure after merge of the rr tree

On Wed, 2 Jun 2010 11:33:45 am Stephen Rothwell wrote:
> Hi Rusty,
> 
> After merging the rr tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> kernel/debug/kdb/kdb_main.c: In function 'kdb_lsmod':
> kernel/debug/kdb/kdb_main.c:1897: error: 'struct module' has no member named 'modules_which_use_me'
> kernel/debug/kdb/kdb_main.c:1897: error: 'struct module' has no member named 'modules_which_use_me'

Thanks Stephen! I'm not surprised Linus (and I) missed this.

Jason/Martin, please don't do this again.  If you need a structure definition
from a file, pull it out into the header don't cut and paste it like
kernel/debug/kdb/kdb_main.c line 1859:

	#if defined(CONFIG_MODULES)
	/* modules using other modules */
	struct module_use {
		struct list_head list;
		struct module *module_which_uses;
	};

I've fixed this as part of the Linus-inspired module locking cleanup which
should hit linux-next tomorrow and -rc2 sometime.

Thanks,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/