linux-kernel - Re: [PATCH] panic: keep blinking in spite of long spin timer mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201006022157.AA00420@tamuki.linet.gr.jp>
Date:	Thu, 03 Jun 2010 06:57:01 +0900
From:	TAMUKI Shoichi <tamuki@...et.gr.jp>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Anton Blanchard <anton@...ba.org>,
	Andy Green <andy@...mcat.com>,
	TAMUKI Shoichi <tamuki@...et.gr.jp>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] panic: keep blinking in spite of long spin timer mode

Hello,

Thank you for the suggestion.

On Sun, 30 May 2010 08:55:22 +0200 Andi Kleen wrote:

> Thanks for this explanation, makes all sense.
> But should do these changes by default then, not with a parameter.

Hmm, that will not be acceptable since the control of blinking speed
becomes difficult with long spin timer mode.

However, I agree to your opinion that it is not the best answer to
prepare purposely a new parameter for such a rare situation.

> Changing the frequency is ok, the only requirement is that it is
> visible and different from the frequency kdb uses.

So, I changed that the time calls to mdelay will be automatically
switched to longer if the speed of blinking is slow enough.  The
kernel parameter (panic_longspin) becomes no longer necessary.

I will soon post the PATCH v2.

Regards,
TAMUKI Shoichi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/