linux-kernel - Re: [B.A.T.M.A.N.] [PATCH] drivers/staging/batman-adv: Convert MAC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201006030156.42370.sven.eckelmann@gmx.de>
Date:	Thu, 3 Jun 2010 01:56:40 +0200
From:	Sven Eckelmann <sven.eckelmann@....de>
To:	Joe Perches <joe@...ches.com>
Cc:	b.a.t.m.a.n@...ts.open-mesh.org,
	devel <devel@...verdev.osuosl.org>, Andrew Lunn <andrew@...n.ch>,
	b.a.t.m.a.n@...ts.open-mesh.net,
	"Greg Kroah-Hartman" <gregkh@...e.de>,
	linux-kernel@...r.kernel.org,
	Simon Wunderlich <siwu@....tu-chemnitz.de>,
	Marek Lindner <lindner_marek@...oo.de>
Subject: Re: [B.A.T.M.A.N.] [PATCH] drivers/staging/batman-adv: Convert MAC_FMT to %pM

Joe Perches wrote:
> On Thu, 2010-06-03 at 01:33 +0200, Sven Eckelmann wrote:
> > Joe Perches wrote:
> > > On Thu, 2010-06-03 at 01:23 +0200, Sven Eckelmann wrote:
> > > > You've also changed the output. So you may partly broke batctl too
> > > > (have to check that first).
> > > 
> > > There was no change in output.
> > > MAC_FMT output is the same as %pM
> > 
> > I meant the other patch :)
> 
> batctl is parsing dmesg or equivalent?  ouch.

It has functionality to parse logfiles which for example could come from 
dmesg.

> If so, may I suggest you consider using something other than
> a message logging parser for batctl?
> 
> I glanced at the source and don't see any such use.
> It looks like it's only /sys, /proc and debugfs,
> but I only spent a few seconds at it.
> 
> http://www.open-mesh.net/changeset/1682/trunk?old_path=%2F&format=zip

see sys.c -> log_print
and read_file -> read_file

Best regards,
	Sven

Download attachment "signature.asc " of type "application/pgp-signature" (837 bytes)