linux-kernel - Re: Add a helper function in PCI IOV to get VF device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 2 Jun 2010 14:12:33 +0800
From:	Frank Pan <frankpzh@...il.com>
To:	"Williams, Mitch A" <mitch.a.williams@...el.com>
Cc:	Greg KH <greg@...ah.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Kenji Kaneshige <kaneshige.kenji@...fujitsu.com>,
	Yu Zhao <yu.zhao@...el.com>,
	Chris Wright <chrisw@...s-sol.org>,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	"David S. Miller" <davem@...emloft.net>,
	Matt Carlson <mcarlson@...adcom.com>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: Add a helper function in PCI IOV to get VF device

> Furthermore, the links are already there in sysfs, created by the PCI subsystem.
>
> /sys/class/net/ethX/device links to the PCI device entry for the PF device, which itself has symlinks to each of the VF devices.
>
> This patch just isn't necessary.

I'm not talking about PF's pci device, because PF
driver knows it. I'm talking about VF's.
The root cause is PF cannot get VF's bdf, so it has
no idea where VF is. IMO it's abnormal.

Make symlinks is just a use case. When a userspace
app only knows VF's bdf, it has no idea how to get
into the VF's interface-like directories.
(/sys/class/net/ethX/vf[1-7])
Because of:
1. Userspace app cannot get PF's bdf from VF's bdf
2. Userspace app cannot guess the interface name of
pf(ethX)
So a symlink from /sys/bus/pci/devices/xxxxx to
/sys/class/net/ethX/vf[1-7] is useful.
This is a real issue.

Thanks for reply.

-- 
Frank Pan

Computer Science and Technology
Tsinghua University
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/