linux-kernel - Re: [PATCH] module: module_unload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201006021555.55007.rusty@rustcorp.com.au>
Date:	Wed, 2 Jun 2010 15:55:54 +0930
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	"linux-kernel" <linux-kernel@...r.kernel.org>,
	Tejun Heo <tj@...nel.org>, Nick Piggin <npiggin@...e.de>
Subject: Re: [PATCH] module: module_unload_init() cleanup

On Wed, 2 Jun 2010 03:46:33 pm Rusty Russell wrote:
> On Wed, 2 Jun 2010 03:02:20 pm Eric Dumazet wrote:
> > No need to clear mod->refptr in module_unload_init(), since
> > alloc_percpu() already clears allocated chunks.
> > 
> > Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> 
> Thanks, applied!
> 
> I know it's trivial, but you should have cc'd Nick since this was his patch.

Hmm, and checked for warnings:

kernel/module.c: In function ‘module_unload_init’:
kernel/module.c:529: warning: unused variable ‘cpu’

Fixed,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/