linux-kernel - Re: Is there a way to change irq numbers of pcie cards ?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4C075D18.8010108@ladisch.de>
Date:	Thu, 03 Jun 2010 09:43:20 +0200
From:	Clemens Ladisch <clemens@...isch.de>
To:	Robert Hancock <hancockrwd@...il.com>
CC:	Bert dd <bert.ddecker@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: Is there a way to change irq numbers of pcie cards ?

Robert Hancock wrote:
> On 06/02/2010 06:08 AM, Bert dd wrote:
> > I have a supermicro machine with 2 raid cards (lsi 9260-8i and lsi 9260-8e) and
> > one nvidia GTX480 graphics card.
> > The problem is that all these pcie cards are assigned the same irq number,
> 
> If you can get MSI enabled for some of those cards, though, that should
> prevent them from sharing interrupts.

The PCIe spec says that all PCIe devices must support MSI interrupts.
(Whether they do in practice is another question ...)

Regardless of the graphics card, enabling MSI for the RAID cards will
prevent their interrupts from interfering with each other.
Bert, you might want to try this completely untested patch:


--- a/drivers/scsi/megaraid/megaraid_sas.c
+++ b/drivers/scsi/megaraid/megaraid_sas.c
@@ -3169,6 +3169,8 @@ megasas_probe_one(struct pci_dev *pdev, const struct pci_device_id *id)
 	if (megasas_init_mfi(instance))
 		goto fail_init_mfi;
 
+	pci_enable_msi(pdev);
+
 	/*
 	 * Register IRQ
 	 */
@@ -3218,6 +3220,7 @@ megasas_probe_one(struct pci_dev *pdev, const struct pci_device_id *id)
 	pci_set_drvdata(pdev, NULL);
 	instance->instancet->disable_intr(instance->reg_set);
 	free_irq(instance->pdev->irq, instance);
+	pci_disable_msi(pdev);
 
 	megasas_release_mfi(instance);
 
@@ -3354,6 +3357,7 @@ megasas_suspend(struct pci_dev *pdev, pm_message_t state)
 	pci_set_drvdata(instance->pdev, instance);
 	instance->instancet->disable_intr(instance->reg_set);
 	free_irq(instance->pdev->irq, instance);
+	pci_disable_msi(pdev);
 
 	pci_save_state(pdev);
 	pci_disable_device(pdev);
@@ -3416,6 +3420,8 @@ megasas_resume(struct pci_dev *pdev)
 	tasklet_init(&instance->isr_tasklet, megasas_complete_cmd_dpc,
 			(unsigned long)instance);
 
+	pci_enable_msi(pdev);
+
 	/*
 	 * Register IRQ
 	 */
@@ -3519,6 +3525,7 @@ static void __devexit megasas_detach_one(struct pci_dev *pdev)
 	instance->instancet->disable_intr(instance->reg_set);
 
 	free_irq(instance->pdev->irq, instance);
+	pci_disable_msi(pdev);
 
 	megasas_release_mfi(instance);
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/