linux-kernel - Re: [patch] padata: add parenthesis in MAX_SEQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100603101937.GA31063@gondor.apana.org.au>
Date:	Thu, 3 Jun 2010 20:19:37 +1000
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Steffen Klassert <steffen.klassert@...unet.com>
Cc:	Dan Carpenter <error27@...il.com>,
	Henrik Kretzschmar <henne@...htwindheim.de>,
	Tejun Heo <tj@...nel.org>, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [patch] padata: add parenthesis in MAX_SEQ_NR macro

On Wed, May 26, 2010 at 08:32:27AM +0200, Steffen Klassert wrote:
> On Tue, May 25, 2010 at 11:29:13PM +0200, Dan Carpenter wrote:
> > MAX_SEQ_NR is used in padata_alloc_pd() like this:
> > 
> >         pd->max_seq_nr = (MAX_SEQ_NR / num_cpus) * num_cpus - 1;
> > 
> > It needs parenthesis or the divide by num_cpus takes precedence over the
> > subtraction.
> > 
> > Signed-off-by: Dan Carpenter <error27@...il.com>
> 
> Acked-by: Steffen Klassert <steffen.klassert@...unet.com>

Applied.  Thanks!
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/