linux-kernel - Re: [PATCH] x86, i8259: Only register sysdev for real PIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100603094546.af7db742.akpm@linux-foundation.org>
Date:	Thu, 3 Jun 2010 09:45:46 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Adam Lackorzynski <adam@...inf.tu-dresden.de>
Cc:	Jacob Pan <jacob.jun.pan@...el.com>,
	"H. Peter Anvin" <hpa@...or.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86, i8259: Only register sysdev for real PIC

On Thu, 3 Jun 2010 11:01:41 +0200 Adam Lackorzynski <adam@...inf.tu-dresden.de> wrote:

> 
> On Wed Jun 02, 2010 at 18:18:14 -0700, Andrew Morton wrote:
> > On Wed, 2 Jun 2010 13:31:50 +0200 Adam Lackorzynski <adam@...inf.tu-dresden.de> wrote:
> > 
> > > Do not register the sysdev function when the null_legacy_pic is used so
> > > that the i8259 resume, suspend and shutdown functions are not called.
> > 
> > What are the effects of this change?  Does it fix an oops or a hang, or
> > nothing at all, or...?
>  
> My platform makes use of the null_legacy_pic choice and oopses when
> doing a shutdown as the shutdown code goes through all the registered
> sysdevs and calls their shutdown method which in my case poke on a
> non-existing i8259. Imho the i8259 specific sysdev should only be
> registered if the i8259 is actually there.

OK, thanks.  Important info, that.  I'd say that makes it something we
should fix in 2.6.34.x and perhaps earlier.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/