linux-kernel - Re: [PATCH 1/2] serial: bfin_5xx: IRDA is not affected by anomaly 05000230

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100603174131.GD9307@kroah.com>
Date:	Thu, 3 Jun 2010 10:41:31 -0700
From:	Greg KH <greg@...ah.com>
To:	Mike Frysinger <vapier@...too.org>
Cc:	linux-serial@...r.kernel.org, Greg Kroah-Hartman <gregkh@...e.de>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	uclinux-dist-devel@...ckfin.uclinux.org,
	linux-kernel@...r.kernel.org, Graf Yang <graf.yang@...log.com>
Subject: Re: [PATCH 1/2] serial: bfin_5xx: IRDA is not affected by anomaly
 05000230

On Mon, May 31, 2010 at 07:29:31AM -0400, Mike Frysinger wrote:
> From: Graf Yang <graf.yang@...log.com>
> 
> Anomaly 05000230 (over sampling of the UART STOP bit) applies only when
> the peripheral is operating in UART mode.  So drop the anomaly handling
> when the UART is in IRDA mode.
> 
> Signed-off-by: Graf Yang <graf.yang@...log.com>
> Signed-off-by: Mike Frysinger <vapier@...too.org>
> ---
>  drivers/serial/bfin_5xx.c |    7 ++++++-
>  1 files changed, 6 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/serial/bfin_5xx.c b/drivers/serial/bfin_5xx.c
> index 96f7e74..a78652b 100644
> --- a/drivers/serial/bfin_5xx.c
> +++ b/drivers/serial/bfin_5xx.c
> @@ -869,7 +869,12 @@ bfin_serial_set_termios(struct uart_port *port, struct ktermios *termios,
>  	}
>  
>  	baud = uart_get_baud_rate(port, termios, old, 0, port->uartclk/16);
> -	quot = uart_get_divisor(port, baud) - ANOMALY_05000230;
> +	quot = uart_get_divisor(port, baud);
> +
> +	/* If discipline is not IRDA, apply ANOMALY_05000230 */
> +	if (termios->c_line != N_IRDA)
> +		quot -= ANOMALY_05000230;
> +

This can't be applied to the current tree, did you make it backwards?

confused,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/