lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 3 Jun 2010 18:57:15 +0100 From: Mark Brown <broonie@...nsource.wolfsonmicro.com> To: Lars-Peter Clausen <lars@...afoo.de> Cc: Ralf Baechle <ralf@...ux-mips.org>, linux-mips@...ux-mips.org, linux-kernel@...r.kernel.org, Liam Girdwood <lrg@...mlogic.co.uk>, alsa-devel@...a-project.org Subject: Re: [RFC][PATCH 26/26] alsa: ASoC: JZ4740: Add qi_lb60 board driver On Wed, Jun 02, 2010 at 09:15:32PM +0200, Lars-Peter Clausen wrote: > + ret = gpio_request(QI_LB60_SND_GPIO, "SND"); > + if (ret) { > + pr_err("qi_lb60 snd: Failed to request SND GPIO(%d): %d\n", > + QI_LB60_SND_GPIO, ret); > + goto err_device_put; > + } > + > + ret = gpio_request(QI_LB60_AMP_GPIO, "AMP"); > + if (ret) { > + pr_err("qi_lb60 snd: Failed to request AMP GPIO(%d): %d\n", > + QI_LB60_AMP_GPIO, ret); > + goto err_gpio_free_snd; > + } > + > + gpio_direction_output(JZ_GPIO_PORTB(29), 0); > + gpio_direction_output(JZ_GPIO_PORTD(4), 0); You're referring to the GPIOs by multiple different names - it'd be more robust to pick one way of naming them and use it consistently (probably the #define). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists