| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <4C08E73B.8050806@fusionio.com> Date: Fri, 04 Jun 2010 13:44:59 +0200 From: Jens Axboe <jaxboe@...ionio.com> To: Mike Snitzer <snitzer@...hat.com> CC: Kiyoshi Ueda <k-ueda@...jp.nec.com>, "dm-devel@...hat.com" <dm-devel@...hat.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Alasdair Kergon <agk@...hat.com> Subject: Re: [PATCH v4] block: avoid unconditionally freeing previously allocated request_queue On 2010-06-03 19:34, Mike Snitzer wrote: > block: avoid unconditionally freeing previously allocated request_queue > > On blk_init_allocated_queue_node failure, only free the request_queue if > it is wasn't previously allocated outside the block layer > (e.g. blk_init_queue_node was blk_init_allocated_queue_node caller). > > This addresses an interface bug introduced by the following commit: > 01effb0 block: allow initialization of previously allocated > request_queue > > Otherwise the request_queue may be free'd out from underneath a caller > that is managing the request_queue directly (e.g. caller uses > blk_alloc_queue + blk_init_allocated_queue_node). Thanks Mike, this looks a lot better. I have applied this one and 2/2 of the original posting. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists