linux-kernel - Re: Makefile.build: make KBUILD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 04 Jun 2010 15:28:30 +0200
From:	Michal Marek <mmarek@...e.cz>
To:	Don Zickus <dzickus@...hat.com>
Cc:	sam@...nborg.org, agruen@...e.de, linux-kernel@...r.kernel.org
Subject: Re: Makefile.build: make KBUILD_SYMTYPES work again

On 24.5.2010 23:07, Don Zickus wrote:
> commit 37a8d9f67f18de1e2cbc7387311ce22d4dbff518 tried to combine some
> duplicate code and accidentally broke how KBUILD_SYMTYPES worked
> 
> This fixes the code to match the original intention by the author who
> originally added the code I believe.
> 
> The fixes include:
> - removing extra whitespaces in the if-statements
> - moving the if-statement from around the -r to the -T
> - adding a second arg to cmd_gensymtypes to simplify the options passed
>   to genksyms.
> 
> Tested by instrumenting genksyms and seeing what options were passed in
> during a make, KBUILD_SYMTYPES make, and when a foo.symref was created.
> 
> Everything compiled and looked ok.
> 
> Signed-off-by: Don Zickus <dzickus@...hat.com>

Thanks. I wrote a very similar patch last year which I thought to have
sent to Sam, but it seems that I haven't (and since then I forgot about
it). Applied now.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/