linux-kernel - Re: [PATCH] lib: fix a memory leak risk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100604152723.GA25400@suse.de>
Date:	Fri, 4 Jun 2010 08:27:23 -0700
From:	Greg KH <gregkh@...e.de>
To:	Wan ZongShun <mcuos.com@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] lib: fix a memory leak risk

On Fri, Jun 04, 2010 at 06:25:28PM +0800, Wan ZongShun wrote:
> The netlink_kernel_create failed will arouse memory leak,
> this patch is to add the 'kfree(ue_sk)' here.
> 
> Signed-off-by: Wan ZongShun <mcuos.com@...il.com>
> 
> ---
>  lib/kobject_uevent.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/lib/kobject_uevent.c b/lib/kobject_uevent.c
> index 59c1551..08e15f7 100644
> --- a/lib/kobject_uevent.c
> +++ b/lib/kobject_uevent.c
> @@ -378,6 +378,7 @@ static int uevent_net_init(struct net *net)
>  	if (!ue_sk->sk) {
>  		printk(KERN_ERR
>  		       "kobject_uevent: unable to create netlink socket!\n");
> +		kfree(ue_sk);

Sorry, others already sent this patch in before you, it's already in the
linux-next tree, and is going to Linus later today.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/