linux-kernel - RE: [PATCH -mmotm] cciss: fix build for CONFIG_PROC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0F5B06BAB751E047AB5C87D1F77A77887D01432795@GVW0547EXC.americas.hpqcorp.net>
Date:	Fri, 4 Jun 2010 18:07:00 +0000
From:	"Miller, Mike (OS Dev)" <Mike.Miller@...com>
To:	Randy Dunlap <randy.dunlap@...cle.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>
Subject: RE: [PATCH -mmotm] cciss: fix build for CONFIG_PROC_FS=n

 

> -----Original Message-----
> From: Randy Dunlap [mailto:randy.dunlap@...cle.com] 
> Sent: Friday, June 04, 2010 11:42 AM
> To: linux-kernel@...r.kernel.org
> Cc: akpm@...ux-foundation.org; Miller, Mike (OS Dev)
> Subject: [PATCH -mmotm] cciss: fix build for CONFIG_PROC_FS=n
> 
> From: Randy Dunlap <randy.dunlap@...cle.com>
> 
> Fix build for CONFIG_PROC_FS not enabled; fixes this build error:
> drivers/block/cciss.c:3422: error: implicit declaration of 
> function 'next_command'
> 
> Looks like the next_command() function was added at a bad 
> location in cciss-add-performant-mode-support-for-stars-sirius.patch.
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>

Thanks, Randy. But I'm working on that plus a couple other miscues.

-- mikem

> Cc: Mike Miller <mike.miller@...com>
> ---
>  drivers/block/cciss.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --- mmotm-2010-0603-1636.orig/drivers/block/cciss.c
> +++ mmotm-2010-0603-1636/drivers/block/cciss.c
> @@ -372,8 +372,6 @@ static const char *raid_label[] = { "0",  
> };  #define RAID_UNKNOWN (sizeof(raid_label) / 
> sizeof(raid_label[0])-1)
>  
> -#ifdef CONFIG_PROC_FS
> -
>  static inline u32 next_command(ctlr_info_t *h)  {
>  	u32 a;
> @@ -396,6 +394,8 @@ static inline u32 next_command(ctlr_info
>  	return a;
>  }
>  
> +#ifdef CONFIG_PROC_FS
> +
>  /*
>   * Report information about this controller.
>   */
> --
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/