linux-kernel - [PATCH 1/5] cciss: fix call to put_controller_in_performant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20100604200511.GA30870@beardog.cce.hp.com>
Date:	Fri, 4 Jun 2010 15:05:11 -0500
From:	Mike Miller <mike.miller@...com>
To:	Andrew Morton <akpm@...ux-foundation.org>,
	Jens Axboe <jens.axboe@...nel.dk>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	LKML-scsi <linux-scsi@...r.kernel.org>, dab@...com,
	scameron@...rdog.cce.hp.com, gerry.morong@...com,
	mike.miller@...com, scott.benesh@...com, scott.stacy.teel@...com,
	tom.lawler@...com, mikem@...rdog.cce.hp.com
Subject: [PATCH 1/5] cciss: fix call to put_controller_in_performant_mode

Patch 1 of 5
cciss: call to put_controller_in_performant_mode was in the wrong place
The call inadvertently ended up in an error path.

From: Mike Miller <mike.miller@...com>

Signed-off-by: Mike Miller <mike.miller@...com>
Cc: Stephen M. Cameron <scameron@...rdog.cce.hp.com>, iss_storagedev@...com
---
 drivers/block/cciss.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c
index 5e215ff..cdc671c 100644
--- a/drivers/block/cciss.c
+++ b/drivers/block/cciss.c
@@ -4150,6 +4150,7 @@ static int __devinit cciss_pci_init(ctlr_info_t *c, struct pci_dev *pdev)
 #ifdef CCISS_DEBUG
 	printk(KERN_WARNING "Trying to put board into Performant mode\n");
 #endif				/* CCISS_DEBUG */
+	cciss_put_controller_into_performant_mode(c);
 	return 0;
 
 err_out_free_res:
@@ -4158,7 +4159,6 @@ err_out_free_res:
 	 * Smart Array controllers that pci_enable_device does not undo
 	 */
 	pci_release_regions(pdev);
-	cciss_put_controller_into_performant_mode(c);
 	return err;
 }
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/