linux-kernel - Re: mmotm 2010-06-03-16-36 uploaded

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTikDzAHHH62Wti1D-iV7pqa6u24BDgigIYO5JZJR@mail.gmail.com>
Date:	Fri, 4 Jun 2010 10:02:57 +0800
From:	Dave Young <hidave.darkstar@...il.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	mm-commits@...r.kernel.org, linux-kernel@...r.kernel.org,
	Len Brown <lenb@...nel.org>,
	pm list <linux-pm@...ts.linux-foundation.org>,
	Thomas Renninger <trenn@...e.de>
Subject: Re: mmotm 2010-06-03-16-36 uploaded

On Fri, Jun 4, 2010 at 9:54 AM, Andrew Morton <akpm@...ux-foundation.org> wrote:
> On Fri, 4 Jun 2010 09:41:58 +0800 Dave Young <hidave.darkstar@...il.com> wrote:
>
>> On Fri, Jun 4, 2010 at 7:36 AM,  <akpm@...ux-foundation.org> wrote:
>> > The mm-of-the-moment snapshot 2010-06-03-16-36 has been uploaded to
>> >
>> > __ http://userweb.kernel.org/~akpm/mmotm/
>> >
>>
>> Hi, intel_idle build fails:
>>
>> drivers/idle/intel_idle.c: In function ___intel_idle___:
>> drivers/idle/intel_idle.c:234: error: too few arguments to function ___trace_power
>> _start___
>> make[2]: *** [drivers/idle/intel_idle.o] Error 1
>> make[1]: *** [drivers/idle] Error 2
>> make[1]: *** Waiting for unfinished jobs....
>>
>
> Caused by
> x86-cpufreq-make-trace_power_frequency-cpufreq-driver-independent.patch
> which changed trace_power_start().
>
> drivers/idle/intel_idle.c wasn't there when Thomas wrote that patch.
>
> this, I guess:
>
> --- a/drivers/idle/intel_idle.c~x86-cpufreq-make-trace_power_frequency-cpufreq-driver-independent-fix
> +++ a/drivers/idle/intel_idle.c
> @@ -231,7 +231,7 @@ static int intel_idle(struct cpuidle_dev
>
>        stop_critical_timings();
>  #ifndef MODULE
> -       trace_power_start(POWER_CSTATE, (eax >> 4) + 1);
> +       trace_power_start(POWER_CSTATE, (eax >> 4) + 1, cpu);
>  #endif
>        if (!need_resched()) {
>

With one more param "cpu", fails with "too many arguments":

  CC      drivers/idle/intel_idle.o
drivers/idle/intel_idle.c: In function ‘intel_idle’:
drivers/idle/intel_idle.c:234: error: too many arguments to function
‘trace_power_start’
make[2]: *** [drivers/idle/intel_idle.o] Error 1
make[1]: *** [drivers/idle] Error 2
make[1]: *** Waiting for unfinished jobs....

> _
>
>
> it's a bit odd that all trace_power_start() callers just pass in
> smp_processor_id().  Why not do it within trace_power_start() itself?
>
>
>



-- 
Regards
dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/