linux-kernel - Re: [PATCH] tracing: reduce latency and remove percpu trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1275620590.15884.70.camel@gandalf.stny.rr.com>
Date:	Thu, 03 Jun 2010 23:03:10 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Lai Jiangshan <laijs@...fujitsu.com>
Cc:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Theodore Tso <tedtso@...il.com>, Theodore Tso <tytso@....edu>
Subject: Re: [PATCH] tracing: reduce latency and remove percpu trace_seq

On Fri, 2010-06-04 at 10:23 +0800, Lai Jiangshan wrote:
> Steven Rostedt wrote:
> 
> > 
> > The "print" in the trace_seq_printf() is the TP_printk() field of the
> > TRACE_EVENT. I believe that there were some events (ext4?) that did
> > things that required preemption disabled.
> > 
> 
> It seems that ext4 has no such events.
> I find jbd2_dev_to_name() in the TP_printk() field of ext4's tracepoints.
> And it seems that jbd2_dev_to_name() requires preemption enabled and sleepable.
> 
> Maybe there were some events did things that required preemption disabled.
> But No document ensure TP_printk() preemption disabled, such events should
> be fixed, I think.

Well, I had a private email conversation with Ted last year where IIRC,
adding the preempt disable would fix things.

I'd like to make sure Ted is OK with removing that before we do so.

Ted?

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/