linux-kernel - Re: [Uclinux-dist-devel] [PATCH v5] regulator: new drivers for AD5398 and AD5821

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTikBtcHTAE-4JrpOM4GGa45MCcVRKs6vK0YMBATc@mail.gmail.com>
Date:	Thu, 3 Jun 2010 23:46:10 -0400
From:	Mike Frysinger <vapier.adi@...il.com>
To:	sonic zhang <sonic.adi@...il.com>
Cc:	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Liam Girdwood <lrg@...mlogic.co.uk>,
	uclinux-dist-devel <uclinux-dist-devel@...ckfin.uclinux.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [Uclinux-dist-devel] [PATCH v5] regulator: new drivers for AD5398 
	and AD5821

On Thu, Jun 3, 2010 at 23:49, sonic zhang wrote:
> +static const struct regulator_ops ad5398_ops = {
> +static const struct regulator_desc ad5398_reg = {

when i said these should be const, this isnt something that can start
with the drivers.  the core needs to be fixed first.  otherwise these
simply trigger warnings.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/