linux-kernel - Re: 2.6.25-rc1 ahci regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100604050022.GF5167@cr0.nay.redhat.com>
Date:	Fri, 4 Jun 2010 13:00:22 +0800
From:	Américo Wang <xiyou.wangcong@...il.com>
To:	Anton Vorontsov <cbouatmailru@...il.com>
Cc:	Américo Wang <xiyou.wangcong@...il.com>,
	Luming Yu <luming.yu@...il.com>, Jeff Garzik <jeff@...zik.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Michal Marek <mmarek@...e.cz>, Sam Ravnborg <sam@...nborg.org>
Subject: Re: 2.6.25-rc1 ahci regression

On Thu, Jun 03, 2010 at 07:55:05PM +0400, Anton Vorontsov wrote:
>On Thu, Jun 03, 2010 at 11:45:33PM +0800, Américo Wang wrote:
>> On Thu, Jun 03, 2010 at 07:04:22PM +0400, Anton Vorontsov wrote:
>> >On Thu, Jun 03, 2010 at 10:13:57PM +0800, Luming Yu wrote:
>> >> On Thu, Jun 3, 2010 at 9:50 PM, Anton Vorontsov <cbouatmailru@...il.com> wrote:
>> >> > On Thu, Jun 03, 2010 at 05:23:19PM +0400, Anton Vorontsov wrote:
>> >> > [...]
>> >> >> Oh. It seems I found it. It must be the module order loading
>> >> >> thing.
>> >> >>
>> >> >> Can you try the patch down below?
>> >> >
>> >> > OTOH... libahci is a link-time dependency. And the order doesn't
>> >> > matter here. So you should just have the libahci module in
>> >> > the initrd (actually, mkinitrd or whatever you use should
>> >> > have included this automatically).
>> >> >
>> >> 
>> >> Neither ahci nor libachi is automatically included in initrd..
>> >
>> >What commands you use to build the kernel and initrd?
>> >
>> >> Manually added ahci and libachi into initrd seems to make the problem go away..
>> >> Any idea why that could happen?
>> >
>> >No idea off hand.
>> >
>> >Cc'ing Kbuild folks. Question is: is there something wrong with
>> >writing stuff like this:
>> >obj-$(CONFIG_SATA_AHCI)         += ahci.o libahci.o
>> >obj-$(CONFIG_SATA_AHCI_PLATFORM) += ahci_platform.o libahci.o
>> >as in drivers/ata/Makefile?
>> >
>> >It seem to link fine, .ko's are created. But for some reason
>> >initrd doesn't include these modules for Luming...
>> >
>> 
>> Odd.
>> Are these modules exported to /lib/modules/`uname -r`/ directory?
>
>At least for me, yes (debian sid). It all looks sane.
>


Then it's unlikely to be a problem of kbuild. :)


>
>I just found Fedora's mkinitrd, and I see this:
>
>~/mkinitrd$ git grep -A 5 -B 5 ahci
>functions-    for m in $items ; do
>functions-      char=$(echo $m | cut -c1)
>functions-      if [ $char = '=' ]; then
>functions-          NAME=$(echo $m | cut -c2-)
>functions-          if [ "$NAME" = "ata" ]; then
>functions:              MODS="$MODS $(cat /lib/modules/$kernel/modules.block |egrep '(ata|ahci)' |sed -e 's/.ko//')"
>functions-          else
>functions-                # Ignore if group list does not exist
>functions-                if [ -e /lib/modules/$kernel/modules.$NAME ]; then
>functions-                  MODS="$MODS $(cat /lib/modules/$kernel/modules.$NAME |sed -e 's/.ko//')"
>functions-                fi
>
>Hm? What is this? Maybe it breaks when it sees libahci?
>

Not sure, Luming is using dracut, I guess if this would be a bug
of dracut, let me check the source code first...

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/