linux-kernel - Re: [PATCH] early_res: fix check in free_early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTimDkEqpGNDkDSy7e8s_ZnCnVuppa6Ut-SLEoHWE@mail.gmail.com>
Date:	Fri, 4 Jun 2010 17:00:02 -0700
From:	Yinghai Lu <yinghai@...nel.org>
To:	Adam Lackorzynski <adam@...inf.tu-dresden.de>
Cc:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH] early_res: fix check in free_early_partial

On Fri, Jun 4, 2010 at 2:10 PM, Adam Lackorzynski
<adam@...inf.tu-dresden.de> wrote:
> free_early_partial must check the returned region of find_overlapped_early()
> whether it is a region at all. Otherwise the function will indefinitely
> loop.

do you have that hang really?

that stage we should not have blank slot in the middle.

Thanks

Yinghai Lu

>
> Signed-off-by: Adam Lackorzynski <adam@...inf.tu-dresden.de>
> ---
>  kernel/early_res.c |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/early_res.c b/kernel/early_res.c
> index 31aa933..9afcb4c 100644
> --- a/kernel/early_res.c
> +++ b/kernel/early_res.c
> @@ -341,10 +341,11 @@ void __init free_early_partial(u64 start, u64 end)
>
>  try_next:
>        i = find_overlapped_early(start, end);
> -       if (i >= max_early_res)
> +       r = &early_res[i];
> +
> +       if (i >= max_early_res || !r->end)
>                return;
>
> -       r = &early_res[i];
>        /* hole ? */
>        if (r->end >= end && r->start <= start) {
>                drop_range_partial(i, start, end);
> --
> 1.7.1
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/