linux-kernel - Re: [PATCH 1/1] LEDS: leds-input, fix sleep inside atomic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100605234505.GZ5358@const.famille.thibault.fr>
Date:	Sun, 6 Jun 2010 01:45:06 +0200
From:	Samuel Thibault <samuel.thibault@...-lyon.org>
To:	Jiri Slaby <jslaby@...e.cz>
Cc:	rpurdie@...ys.net, akpm@...ux-foundation.org,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	jirislaby@...il.com
Subject: Re: [PATCH 1/1] LEDS: leds-input, fix sleep inside atomic

Jiri Slaby, le Sat 05 Jun 2010 23:12:22 +0200, a écrit :
> Fix this by changing the spinlock to mutex as it is used only in
> input_handler->connect and ->disconnect and it is safe to sleep
> there.

Right. in a previous patch it was also used in interrupt context, but
now it should be safe indeed.

Andrew, please fold it into the leds-input patch.

> Signed-off-by: Jiri Slaby <jslaby@...e.cz>
> Cc: Richard Purdie <rpurdie@...ys.net>
Acked-by: Samuel Thibault <samuel.thibault@...-lyon.org>

BTW, please also Cc authors of files when reporting bugs... :)

Samuel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/