linux-kernel - [PATCH] remove pointless debug printk in rt_ioctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <1275712909.8509.25.camel@debian-hell>
Date:	Sat, 05 Jun 2010 06:41:49 +0200
From:	Giangiacomo Mariotti <giangiacomo.mariotti@...il.com>
To:	LKML <linux-kernel@...r.kernel.org>
Cc:	gregkh@...e.de, bzolnier@...il.com, roel.kluin@...il.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: [PATCH] remove pointless debug printk in rt_ioctl_giwscan()

This debug printk is only useful if you're debugging the staging drivers
2860 e 2870, but, if you're just using them, it becomes really annoying, because
it uselessly clobbers the kernel log. I guess this patch shouldn't really get merged,
but it's more like a request to remove these annoying debugging messages for normal users.
If I get any suggestion on how to implement this in a way acceptable to get it merged, I'll
be happy to create the "good" version  of the patch.

Thanks,

Giangiacomo

>From b24cc30ddad0bcd9a1fe00a7ecdd5dba4a3a4d06 Mon Sep 17 00:00:00 2001
From: Giangiacomo Mariotti <giangiacomo.mariotti@...il.com>
Date: Sat, 5 Jun 2010 05:39:58 +0200
Subject: [PATCH] remove pointless debug printk in rt_ioctl_giwscan()


Signed-off-by: Giangiacomo Mariotti <giangiacomo.mariotti@...il.com>
---
 drivers/staging/rt2860/sta_ioctl.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rt2860/sta_ioctl.c b/drivers/staging/rt2860/sta_ioctl.c
index de4b627..f9aa6f2 100644
--- a/drivers/staging/rt2860/sta_ioctl.c
+++ b/drivers/staging/rt2860/sta_ioctl.c
@@ -1116,9 +1116,9 @@ int rt_ioctl_giwscan(struct net_device *dev,
 
 	data->length = current_ev - extra;
 	pAdapter->StaCfg.bScanReqIsFromWebUI = FALSE;
-	DBGPRINT(RT_DEBUG_ERROR,
+	/*DBGPRINT(RT_DEBUG_ERROR,
 		 ("===>rt_ioctl_giwscan. %d(%d) BSS returned, data->length = %d\n",
-		  i, pAdapter->ScanTab.BssNr, data->length));
+		  i, pAdapter->ScanTab.BssNr, data->length));*/
 	return 0;
 }
 
-- 
1.7.1


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/