[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sun, 06 Jun 2010 23:09:28 +0200
From: Wolfgang Denk <wd@...x.de>
To: Rupjyoti Sarmah <rsarmah@...c.com>
cc: linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org,
sr@...x.de, Josh Boyer <jwboyer@...ux.vnet.ibm.com>,
linuxppc-dev@...abs.org, jgarzik@...ox.com
Subject: Re: [PATCH]460EX on-chip SATA driver<kernel 2.6.33><resubmission>
Dear Rupjyoti Sarmah,
In message <201006041226.o54CQH2V017366@...c.com> you wrote:
> This patch enables the on-chip DWC SATA controller of the AppliedMicro processor 460EX.
>
> Signed-off-by: Rupjyoti Sarmah <rsarmah@...liedmicro.com>
> Signed-off-by: Mark Miesfeld <mmiesfeld@...liedmicro.com>
> Signed-off-by: Prodyut Hazarika <phazarika@...liedmicro.com>
>
> ---
> drivers/ata/Kconfig | 9 +
> drivers/ata/Makefile | 1 +
> drivers/ata/sata_dwc_460ex.c | 1808 ++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 1818 insertions(+), 0 deletions(-)
> create mode 100644 drivers/ata/sata_dwc_460ex.c
This driver needs fixing. It will not compile against recent kernel
versions.
...
> diff --git a/drivers/ata/sata_dwc_460ex.c b/drivers/ata/sata_dwc_460ex.c
> new file mode 100644
> index 0000000..e6e2896
> --- /dev/null
> +++ b/drivers/ata/sata_dwc_460ex.c
> @@ -0,0 +1,1808 @@
...
> +#include <linux/kernel.h>
> +#include <linux/module.h>
> +#include <linux/init.h>
> +#include <linux/device.h>
> +#include <linux/of_platform.h>
> +#include <linux/libata.h>
> +#include "libata.h"
> +
> +#include <scsi/scsi_host.h>
> +#include <scsi/scsi_cmnd.h>
You miss a "#include <linux/slab.h>" here.
...
> + for (i = 0; i < SATA_DWC_QCMD_MAX; i++)
> + hsdevp->cmd_issued[i] = SATA_DWC_CMD_ISSUED_NOT;
> +
> + ap->prd = 0; /* set these so libata doesn't use them */
> + ap->prd_dma = 0;
s/prd/bmdma_prd/ in these two lines (cf. commit f60d7011).
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@...x.de
He had quite a powerful intellect, but it was as powerful like a
locomotive, and ran on rails and was therefore almost impossible to
steer. - Terry Pratchett, _Lords and Ladies_
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists