linux-kernel - OMAP video compile error; regression from 2.6.33-rc4 onward (including current master)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 6 Jun 2010 16:52:25 -0500
From:	"Luke-Jr" <luke@...hjr.org>
To:	tomi.valkeinen@...ia.com, slapin@...fans.org
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-omap@...r.kernel.org
Subject: OMAP video compile error; regression from 2.6.33-rc4 onward (including current master)

This doesn't even build, so I don't know how it was tested... Reverting the 
offending commit (simple, but does require conflict resolution) at least lets 
it compile, but I haven't tested whether it alone is enough to work in 
practise yet... hoping Tomi might provide a real fix. Maybe even in time for 
2.6.35 final? :)

https://bugzilla.kernel.org/show_bug.cgi?id=16144

CC      drivers/video/omap/rfbi.o                                               
drivers/video/omap/rfbi.c: In function 'rfbi_get_clocks':                       
drivers/video/omap/rfbi.c:86: error: 'dispc' undeclared (first use in this
function)
drivers/video/omap/rfbi.c:86: error: (Each undeclared identifier is reported
only once
drivers/video/omap/rfbi.c:86: error: for each function it appears in.)          
make[1]: *** [drivers/video/omap/rfbi.o] Error 1                                
make: *** [drivers/video/omap/rfbi.o] Error 2                                   

The 'dispc' referred to herein is and has always been defined in
drivers/video/omap/dispc.c as an anonymous struct.

Broken in...
commit f778a12dd33200513596a0d4d3ba4d5f09e79c09
Author: Tomi Valkeinen <tomi.valkeinen@...ia.com>
Date:   Wed Dec 16 13:18:07 2009 +0200

    OMAP: OMAPFB: fix clk_get for RFBI

    omapfb platform device was still used to get clocks inside rfbi.c

    Signed-off-by: Tomi Valkeinen <tomi.valkeinen@...ia.com>
    Tested-by: Sergey Lapin <slapin@...fans.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/