linux-kernel - Re: [PATCH] usb-serial/ftdi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C0B6B52.5050702@xs4all.nl>
Date:	Sun, 06 Jun 2010 11:33:06 +0200
From:	Ruud Linders <kernelml@...all.nl>
To:	Daniel Mack <daniel@...aq.de>
CC:	linux-kernel@...r.kernel.org, Greg Kroah-Hartman <gregkh@...e.de>,
	Johan Hovold <jhovold@...il.com>,
	Alan Cox <alan@...ux.intel.com>, linux-usb@...r.kernel.org
Subject: Re: [PATCH] usb-serial/ftdi_sio: fix DTR/RTS line modes


On 06/03/2010 01:57 PM, Daniel Mack wrote:
> On Thu, Jun 03, 2010 at 01:55:02PM +0200, Daniel Mack wrote:
>> Call set_mctrl() and clear_mctrl() according to the flow control mode
>> selected. This makes serial communication for FT232 connected devices
>> work when CRTSCTS is not set.
>>
>> This fixes a regression introduced by 4175f3e31 ("tty_port: If we are
>> opened non blocking we still need to raise the carrier"). This patch
>> calls the low-level driver's dtr_rts() function which consequently sets
>> TIOCM_DTR | TIOCM_RTS. A later call to set_termios() without CRTSCTS in
>> cflags, however, does not reset these bits, and so data is not actually
>> sent out on the serial wire.
>>
>> Signed-off-by: Daniel Mack <daniel@...aq.de>
>> Cc: Greg Kroah-Hartman <gregkh@...e.de>
>> Cc: Johan Hovold <jhovold@...il.com>
>> Cc: Alan Cox <alan@...ux.intel.com>
>> Cc: linux-usb@...r.kernel.org
> 
> Oops. I forgot to Cc: stable@...nel.org.
> This is in fact broken since 2.6.31-something.
> 
> 
> 
> 
>> ---
>>  drivers/usb/serial/ftdi_sio.c |    4 ++++
>>  1 files changed, 4 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c
>> index 050211a..79dd1ae 100644
>> --- a/drivers/usb/serial/ftdi_sio.c
>> +++ b/drivers/usb/serial/ftdi_sio.c
>> @@ -2005,6 +2005,8 @@ static void ftdi_set_termios(struct tty_struct *tty,
>>  				"urb failed to set to rts/cts flow control\n");
>>  		}
>>  
>> +		/* raise DTR/RTS */
>> +		set_mctrl(port, TIOCM_DTR | TIOCM_RTS);
>>  	} else {
>>  		/*
>>  		 * Xon/Xoff code
>> @@ -2052,6 +2054,8 @@ static void ftdi_set_termios(struct tty_struct *tty,
>>  			}
>>  		}
>>  
>> +		/* lower DTR/RTS */
>> +		clear_mctrl(port, TIOCM_DTR | TIOCM_RTS);
>>  	}
>>  	return;
>>  }
>> -- 
>> 1.7.1
>>
> --

Hmm, I tried this patch on plain 2.6.34 but still have a problem.
As you indicated since 2.6.31-something something is broken.

I'm using a receive only device (http://rfxcom.com/receivers.htm)
which works fine until the system becomes more busy, usually it runs
almost idle and all is fine.

However, when this happens, it appears the received characters get
buffered somewhere as nothing seems to get through or is delayed for
many minutes.
When I then =write= a character to the serial device
	echo > /dev/ttyUSB0
the data is received in sudden burst, seems no data is actually lost
just seriously delayed.

Any ideas ?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/