linux-kernel - Re: [PATCH] genalloc: fix allocation from end of pool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 7 Jun 2010 10:18:45 +0900
From:	Akinobu Mita <akinobu.mita@...il.com>
To:	imre.deak@...ia.com
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Zygo Blaxell <zygo.blaxell@...dros.com>,
	Tejun Heo <tj@...nel.org>
Subject: Re: [PATCH] genalloc: fix allocation from end of pool

2010/6/5  <imre.deak@...ia.com>:
> From: Imre Deak <imre.deak@...ia.com>
>
> bitmap_find_next_zero_area requires the size of the bitmap, we instead
> passed the last suitable position. This made it impossible to allocate
> from the end of the pool.

Looks good to me.
This bug was introduced by commit 243797f59b748f679ab88d456fcc4f92236d724b
("genalloc: use bitmap_find_next_zero_area")

> Signed-off-by: Imre Deak <imre.deak@...ia.com>
> CC: Andrew Morton <akpm@...ux-foundation.org>
> CC: Zygo Blaxell <zygo.blaxell@...dros.com>
> CC: Tejun Heo <tj@...nel.org>
> CC: Akinobu Mita <akinobu.mita@...il.com>
>
> ---
>  lib/genalloc.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/lib/genalloc.c b/lib/genalloc.c
> index 736c3b0..1923f14 100644
> --- a/lib/genalloc.c
> +++ b/lib/genalloc.c
> @@ -128,7 +128,6 @@ unsigned long gen_pool_alloc(struct gen_pool *pool, size_t size)
>                chunk = list_entry(_chunk, struct gen_pool_chunk, next_chunk);
>
>                end_bit = (chunk->end_addr - chunk->start_addr) >> order;
> -               end_bit -= nbits + 1;
>
>                spin_lock_irqsave(&chunk->lock, flags);
>                start_bit = bitmap_find_next_zero_area(chunk->bits, end_bit, 0,
> --
> 1.7.1
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/