linux-kernel - Re: [PATCH v6] regulator: new drivers for AD5398 and AD5821

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100607122840.GA13287@rakim.wolfsonmicro.main>
Date:	Mon, 7 Jun 2010 13:28:41 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	sonic zhang <sonic.adi@...il.com>
Cc:	Liam Girdwood <lrg@...mlogic.co.uk>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	uclinux-dist-devel <uclinux-dist-devel@...ckfin.uclinux.org>
Subject: Re: [PATCH v6] regulator: new drivers for AD5398 and AD5821

On Fri, Jun 04, 2010 at 12:40:46PM +0800, sonic zhang wrote:

> The AD5398 and AD5821 are single 10-bit DAC with 120 mA output current
> sink capability. They feature an internal reference and operates from
> a single 2.7 V to 5.5 V supply.

> This driver supports both the AD5398 and the AD5821.  It adapts into the
> voltage and current framework.

> Signed-off-by: Sonic Zhang <sonic.zhang@...log.com>
> Signed-off-by: Mike Frysinger <vapier@...too.org>

Acked-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>

but

> +static int __init ad5398_init(void)
> +{
> +	return i2c_add_driver(&ad5398_driver);
> +}
> +module_init(ad5398_init);

at least some systems are likely to want this to be subsys_initcall() to
make sure the regulator is available prior to the consumers.  Please
send an incremental change for this rather than repostnig the full
thing.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/