linux-kernel - Re: [git pull] drm fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1006071409320.4506@i5.linux-foundation.org>
Date:	Mon, 7 Jun 2010 14:17:23 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	David Woodhouse <dwmw2@...radead.org>
cc:	Al Viro <viro@...IV.linux.org.uk>, Dave Airlie <airlied@...ux.ie>,
	dri-devel@...ts.freedesktop.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [git pull] drm fixes

On Mon, 7 Jun 2010, David Woodhouse wrote:
> 
> The fix is fairly trivial. There's a "big" patch to fs/jffs2/dir.c which
> accounts for the bulk of my pull request, but if you look harder you'll
> see it's mostly just a bunch of removing 'return ret;' and adding 
> 'goto fail;' so the error cleanup happens properly.

So that's the part I'm worried about.

I'm going to be hardnosed, but I'm _not_ going to so hardnosed as to worry 
about some oneliner DocBook patch. It's not about being anal to quite that 
degree, that would be silly. But the dir.c change is what I end up 
worrying about.

It's not at all clear why it's good to change

	jffs2_clear_inode(inode);

into

	make_bad_inode(inode);
	iput(inode);

and that changelog doesn't really explain it either ("fix leak"? Ok, I can 
see the iput() fixing the leak - but you also did that jffs2_clear_inode() 
change, and that has no explanation what-so-ever.

So is this a safe thing that definitely fixes a serious bug? I am left 
with no good way to judge.

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/