linux-kernel - Re: [git pull] drm fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1006071436160.4506@i5.linux-foundation.org>
Date:	Mon, 7 Jun 2010 14:38:09 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Al Viro <viro@...IV.linux.org.uk>
cc:	David Woodhouse <dwmw2@...radead.org>,
	Dave Airlie <airlied@...ux.ie>,
	dri-devel@...ts.freedesktop.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [git pull] drm fixes



On Mon, 7 Jun 2010, Al Viro wrote:

> On Mon, Jun 07, 2010 at 02:17:23PM -0700, Linus Torvalds wrote:
> > 	jffs2_clear_inode(inode);
> > 
> > into
> > 
> > 	make_bad_inode(inode);
> > 	iput(inode);
> > 
> > and that changelog doesn't really explain it either ("fix leak"? Ok, I can 
> > see the iput() fixing the leak - but you also did that jffs2_clear_inode() 
> > change, and that has no explanation what-so-ever.
> 
> The final iput() calls ->clear_inode() (jffs2_clear_inode in case of jffs2)
> and the inode has just been created, with no other in-core references
> existing.  Basically, that call was the only part of (required) iput() that
> _was_ done there ;-)
> 
> FWIW, what's happening around ->clear_inode()/->delete_inode()/->drop_inode()
> is a mess.  This leak got found when I'd been looking through that crap;
> results of sanitizing are in #evict_inode (vfs-2.6.git).  I'm going to shift
> that into for-next tomorrow, assuming it survives local beating.  For now
> I've just pulled jffs2-fixes in it...

Ok, a changelog like that would have been a good thing. Not that I usually 
care, but now that I'm in careful mode, I do end up looking at things like 
this, and a good changelog would have goen m uch further in convincing me 
that the "goto fail" changes really were just about fixing the leak, and 
that there wasn't some other change hidden in the same commit.

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/