linux-kernel - Re: [rtc-linux] [PATCH] rtc: driver for the DryIce block found in i.MX25 chips

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100607052027.GG14583@jasper.tkos.co.il>
Date:	Mon, 7 Jun 2010 08:20:28 +0300
From:	Baruch Siach <baruch@...s.co.il>
To:	Wan ZongShun <mcuos.com@...il.com>
Cc:	rtc-linux@...glegroups.com, linux-kernel@...r.kernel.org,
	Alessandro Zummo <a.zummo@...ertech.it>
Subject: Re: [rtc-linux] [PATCH] rtc: driver for the DryIce block found in
 i.MX25 chips

Hi Wan,

On Sat, Jun 05, 2010 at 11:08:46PM +0800, Wan ZongShun wrote:
> Some minor comments below:

One question though.

> > +/*
> > + * read the seconds portion of the current time from the dryice time counter
> > + */
> > +static int dryice_rtc_read_time(struct device *dev, struct rtc_time *tm)
> > +{
> > +       struct imxdi_dev *imxdi = dev_get_drvdata(dev);
> > +       unsigned long now;
> > +
> > +       now = __raw_readl(imxdi->ioaddr + DTCMR);
> > +       rtc_time_to_tm(now, tm);
> > +
> 
> When we want to return a tm value, call rtc_valid_tm() to check the tm
> that is a good habit.

Isn't rtc_time_to_tm() guaranteed to produce a valid tm value?

> 
> > +       return 0;
> > +}

baruch

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@...s.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/