linux-kernel - Re: [PATCH 2/2] mmc: fix mmc card disappearence on resume on ricoh mmc controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1275987156.30596.6.camel@dell16>
Date:	Tue, 08 Jun 2010 11:52:36 +0300
From:	Maxim Levitsky <maximlevitsky@...il.com>
To:	Chris Ball <cjb@...top.org>
Cc:	"linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
	Philip Langdale <philipl@...rt.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] mmc: fix mmc card disappearence on resume on ricoh
	mmc controllers

On Mon, 2010-06-07 at 01:47 -0400, Chris Ball wrote:
> Hi Maxim,
> 
>    >> It looks like your editor is set to four-space instead of
>    >> eight-space tab characters, else you wouldn't be using so
>    >> many tabs here.
> 
>    > Nope, I think indention is right here.
>    >
>    > the break is inside 'if' condition.
> 
> Please look again, I think you're mistaken.  For example, why do you
> use seven tab characters for the "& SDHCI_CARD_PRESENT" after the if
> line?  With eight-space tabs, it looks like this (converted to
> spaces):
> 
> +                       if (sdhci_readl(host, SDHCI_PRESENT_STATE)
> +                                                       & SDHCI_CARD_PRESENT) {
Ah, this.

I just break the line to avoid hitting the 80 char limit...

You probably meant I need to write:

+                       if (sdhci_readl(host, SDHCI_PRESENT_STATE)
+                                & SDHCI_CARD_PRESENT) {

Nothing against it,

Best regards,
	Maxim Levitsky

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/