linux-kernel - Re: [PATCH][RFC] tracing: Use class->reg() for all registering of events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100608173559.GE2800@linux.vnet.ibm.com>
Date:	Tue, 8 Jun 2010 23:05:59 +0530
From:	Srikar Dronamraju <srikar@...ux.vnet.ibm.com>
To:	Peter Zijlstra <peterz@...radead.org>, rostedt@...dmis.org
Cc:	LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	Ananth N Mavinakayanahalli <ananth@...ibm.com>
Subject: Re: [PATCH][RFC] tracing: Use class->reg() for all registering of
 events

> On Tue, 2010-06-08 at 11:33 -0400, Steven Rostedt wrote:
> > I'm pushing this as an RFC first. This probably should be something that
> > makes it into 2.6.35.
> > 
> > Acks and perhaps a little testing from the perf and kprobe angle?
> 
> I'll have a look soon, but lets add Srikar to CC, he actually reported
> the problem :-)
> 
> > Steven Rostedt (1):
> >       tracing: Use class->reg() for all registering of evints
> > 

I tested the patch and it fixed the regression where
perf record -e probe:do_fork -aR sleep 1 would fail. 

Now with this patch, it records the events. However perf record
encounters a floating point exception .. (Peter said he was aware and had a
fix for the floating point exception problem)

However I still see another minor regression (atleast on the tip tree)
This regression was present even before this patch.
The first time I run a perf probe command, it fails, subsequent runs
pass. 

i.e 

411 [srikar@...69 ]$  sudo perf probe do_fork 
kprobe_events file does not exist - please rebuild kernel with CONFIG_KPROBE_EVENT.
  Error: Failed to add events. (-1)
411 [srikar@...69 ]$  sudo perf probe do_fork 
Add new event:
  probe:do_fork        (on do_fork)

You can now use it on all perf tools, such as:

        perf record -e probe:do_fork -aR sleep 1

411 [srikar@...69 ]$ 

--
Thanks and Regards
Srikar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/