linux-kernel - Re: [rfc] Describe events in a structured way via sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100608184354.GO11585@elte.hu>
Date:	Tue, 8 Jun 2010 20:43:54 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Lin Ming <ming.m.lin@...el.com>,
	Steven Rostedt <rostedt@...dmis.org>
Cc:	Peter Zijlstra <peterz@...radead.org>, Greg KH <greg@...ah.com>,
	Corey Ashford <cjashfor@...ux.vnet.ibm.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Paul Mundt <lethal@...ux-sh.org>,
	"eranian@...il.com" <eranian@...il.com>,
	"Gary.Mohr@...l.com" <Gary.Mohr@...l.com>,
	"arjan@...ux.intel.com" <arjan@...ux.intel.com>,
	"Zhang, Yanmin" <yanmin_zhang@...ux.intel.com>,
	Paul Mackerras <paulus@...ba.org>,
	"David S. Miller" <davem@...emloft.net>,
	Russell King <rmk+kernel@....linux.org.uk>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Will Deacon <will.deacon@....com>,
	Maynard Johnson <mpjohn@...ibm.com>,
	Carl Love <carll@...ibm.com>,
	Kay Sievers <kay.sievers@...y.org>,
	lkml <linux-kernel@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [rfc] Describe events in a structured way via sysfs


* Lin Ming <ming.m.lin@...el.com> wrote:

> 
> > * Peter Zijlstra <peterz@...radead.org> wrote:
> > 
> > > On Thu, 2010-05-20 at 16:12 -0700, Greg KH wrote:
> > 
> > > > How deep in the device tree are you really going to be
> > > > caring about?  It sounds like the large majority of
> > > > events are only going to be coming from the "system"
> > > > type objects (cpu, nodes, memory, etc.) and very few
> > > > would be from things that we consider a 'struct
> > > > device' today (like a pci, usb, scsi, or input, etc.)
> > >
> > > The general noise I hear from the hardware people is
> > > that we'll see more and more device-level stuff - bus
> > > bridges/controller and actual devices (GPUs, NICs etc.)
> > > will be wanting to export performance metrics.
> > 
> > There's (much) more:
> > 
> >  - laptops want to provide power level/usage metrics,
> > 
> >  - we could express a lot of special, lower level
> >   (transport specific) disk IO stats via events as well -
> >   without having to push those stats to a higher level
> >   (where it might not make sense). Currently such kinds
> >   of stats/metrics are very device/subsystem specific
> >   way, if they are provided at all.
> > 
> > Also, we already have quite a few per device tracepoints
> > upstream. Here are a few examples:
> > 
> >  - GPU tracepoints (trace_i915_gem_request_submit(), etc.)
> >  - WIFI tracepoints (trace_iwlwifi_dev_ioread32(), etc.)
> >  - block tracepoints (trace_block_bio_complete())
> > 
> > So these would be attached to:
> > 
> >  # GEM events of drm/card0:
> >  /sys/devices/pci0000:00/0000:00:02.0/drm/card0/events/i915_gem_request_submit/
> > 
> >  # Wifi-ioread events of wlan0:
> >  /sys/devices/pci0000:00/0000:00:1c.1/0000:03:00.0/net/wlan0/events/iwlwifi_dev_ioread32/
> > 
> >  # whole sdb disk events:
> >  /sys/block/sdb/events/block_bio_complete/
> > 
> >  # sdb1 partition events:
> >  /sys/block/sdb/sdb1/events/block_bio_complete/
> > 
> 
> The difficulty is how to know where each event should be attached to.
> 
> struct ftrace_event_call *call;
> 
> for_each_event(call, __start_ftrace_events, __stop_ftrace_events) {
> 	/* where will this event be attached to?  */
> }
> 
> Any idea?

Well, it cannot be automatic - for each subsystem it's a different sysfs 
point. So it has to be specified in the TRACE_EVENT() definition or so.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/