linux-kernel - Re: setting miscdevice.parent after misc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100608193418.GF3788@infomag.iguana.be>
Date:	Tue, 8 Jun 2010 21:34:18 +0200
From:	Wim Van Sebroeck <wim@...ana.be>
To:	Akinobu Mita <akinobu.mita@...il.com>
Cc:	Hans-Christian Egtvedt <hcegtvedt@...el.com>,
	linux-kernel@...r.kernel.org
Subject: Re: setting miscdevice.parent after misc_register()

Hi Akinobu,

> In drivers/watchdog/at32ap700x_wdt.c, and drivers/watchdog/sch311x_wdt.c
> miscdevice.parent is set after misc_register().
> 
> drivers/watchdog/at32ap700x_wdt.c:
> 
> 	ret = misc_register(&wdt->miscdev);
> 	...
> 	wdt->miscdev.parent = &pdev->dev;
> 
> But it does nothing. (the miscdevice will not be a child of that parent
> device in sysfs)
> 
> So should it be set before misc_register() or just keep it as-is?

It should be fixed by setting it before the misc_register call.
I'll do the necessary.

Thanks,
Wim.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/