linux-kernel - Re: Add a helper function in PCI IOV to get VF device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100608143514.740f8095@virtuousgeek.org>
Date:	Tue, 8 Jun 2010 14:35:14 -0700
From:	Jesse Barnes <jbarnes@...tuousgeek.org>
To:	Frank Pan <frankpzh@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Kenji Kaneshige <kaneshige.kenji@...fujitsu.com>,
	Yu Zhao <yu.zhao@...el.com>,
	Chris Wright <chrisw@...s-sol.org>,
	Mitch Williams <mitch.a.williams@...el.com>,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	"David S. Miller" <davem@...emloft.net>,
	Matt Carlson <mcarlson@...adcom.com>,
	linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: Add a helper function in PCI IOV to get VF device

On Tue, 1 Jun 2010 13:05:25 +0800
Frank Pan <frankpzh@...il.com> wrote:

> Greetings,
> 
> The motivation is make VF device visible to PF driver. PF driver
> may need this to access VF's PCI configuration.
> Another use case is in sysfs symbolic linking. Some of VF's sysfs
> entries are created by PF driver. For example, /sys/class/net/ethx/vfx
> in Intel 82576 NIC driver. Makeing a symbolic link from VF's pci device
> to this path also must be done in PF's driver.
> 
> Currently, there is no hint about VF's bus/devfn in PF's pci_dev.
> The offset and stride entries(which are used to calculate bus/devfn
> of VF devices) in VF's PCI configuration is also invisible in PF's
> driver. So IMO this helper function is needed.
> 
> Any reply is appreciated, THX.
> 
> (ps: gmail will do line wrap/tab replace, use attachment instead to patch)

Per the discussion in this thread it sounds like this really has
nothing to do with sysfs and more to do with being a convenient API for
drivers.

Is that correct?  If so, and assuming there's not some other way of
getting this info from a driver, I'm ok with it, but it should be
submitted as part of a patchset including driver code that uses it.

-- 
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/