linux-kernel - Re: [PATCH -v2] pci: clear bridge resource size if BIOS assign bad one

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100608144350.366071fd@virtuousgeek.org>
Date:	Tue, 8 Jun 2010 14:43:50 -0700
From:	Jesse Barnes <jbarnes@...tuousgeek.org>
To:	Yinghai Lu <yinghai.lu@...cle.com>
Cc:	Bjorn Helgaas <bjorn.helgaas@...com>,
	Yannick Roehlly <yannick.roehlly@...e.fr>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -v2] pci: clear bridge resource size if BIOS assign bad
 one

On Thu, 03 Jun 2010 13:43:03 -0700
Yinghai Lu <yinghai.lu@...cle.com> wrote:

> 
> Make sure We can reject wrong size from BIOS.
> 
> https://bugzilla.kernel.org/show_bug.cgi?id=16009
> Yannick found that video does not work with 2.6.34
> 
> the root cause:
> BIOS assigned wrong range to pci bridge.  and before 2.6.34 kernel will
> just get range that is needed.
> for 2.6.34.
> |	d65245c PCI: don't shrink bridge resources
> will try to range size is bigger than old one.
> (used by boot stage multi-try to get big BAR size for pci bridge,
>  and pcie hotplug to get big range)
> 
> So try to 0 for old size for pci bridge in this boot stage case.
> 
> Reported-by: Yannick <yannick.roehlly@...e.fr>
> Analyzed-by: Bjorn Helgaas <bjorn.helgaas@...com>
> Signed-off-by: Yinghai Lu <yinghai@...nel.org>
> 

Bjorn, are you ok with this version?  It would probably help to have
some comments here too (I can add them), indicating that we'll try to
reassign the resource later, rather than just ignoring it as the
existing comment implies.

-- 
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/