linux-kernel - Re: [PATCH, v2] kbuild: Improve version string logic - two for the price of one

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1006072311170.31780@chino.kir.corp.google.com>
Date:	Mon, 7 Jun 2010 23:18:42 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	Boaz Harrosh <bharrosh@...asas.com>
cc:	Ingo Molnar <mingo@...e.hu>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Frans Pop <elendil@...net.nl>,
	Dirk Hohndel <hohndel@...radead.org>,
	Len Brown <lenb@...nel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH, v2] kbuild: Improve version string logic - two for the
 price of one - No thanks

On Tue, 8 Jun 2010, Boaz Harrosh wrote:

> >> I already have my:
> >>  VERSION = 2
> >>  PATCHLEVEL = 6
> >>  SUBLEVEL = 35
> >> -EXTRAVERSION = -rc2
> >> +EXTRAVERSION = -rc2-my_tree
> >>
> > 
> > You shouldn't be using EXTRAVERSION for this purpose, you should be 
> > passing LOCALVERSION=my_tree to make.
> > 
> 
> That will not work because the way I run make is out of my control. Every
> one in the working group has his system. The Makefile is part of the
> public git tree, so every one will get the same identification without
> any confusion with Vanilla kernel, or what was compiled.
> 

If everyone using that tree wants the same version string for that kernel, 
use CONFIG_LOCALVERSION="-my_tree" in your .config and use "make 
LOCALVERSION=".

> > Unless it's a vanilla 2.6.35-rc2 kernel, it's inaccurate to persent it as 
> > 2.6.35-rc2; you'll need to pass LOCALVERSION to make to identify this as a 
> > non-vanilla kernel.
> 
> What are we lawyers? come on. And I do not have that problem! The output will
> not be 2.6.35-rc2 as you fear. It will be 2.6.35-rc2-my-tree-my-version.

That's because you're using EXTRAVERSION which is also used upstream to 
describe kernel releases (stable, rc, mm, etc).

> Please stop this *none-sense* this is not your place to mandate my Kernel name. If
> I'm forced to have an external Makefile I can just "mv" what ever name I choose.
> The Kernel name is an ABI you have just broken that, You must revert it ASAP.
> 

You still have the tools available to do everything you once did.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/