linux-kernel - Re: [RFC PATCH 1/2] mac80211: make max_network

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1276076287.3727.15.camel@jlt3.sipsolutions.net>
Date:	Wed, 09 Jun 2010 11:38:07 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	florian@...kler.org
Cc:	pm list <linux-pm@...ts.linux-foundation.org>,
	james.bottomley@...e.de, markgross@...gnar.org,
	mgross@...ux.intel.com,
	"John W. Linville" <linville@...driver.com>,
	"David S. Miller" <davem@...emloft.net>,
	Javier Cardona <javier@...ybit.com>, Jouni Malinen <j@...fi>,
	Rui Paulo <rpaulo@...il.com>,
	Kalle Valo <kalle.valo@...ia.com>,
	linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [RFC PATCH 1/2] mac80211: make max_network_latency notifier
 atomic safe

On Wed, 2010-06-09 at 11:15 +0200, florian@...kler.org wrote:
> In order to have the pm_qos framework be callable from interrupt
> context, all listeners have to also be callable in that context.

That makes no sense at all. Why add work structs _everywhere_ in the
callees and make the API harder to use and easy to get wrong completely,
instead of just adding a single work struct that will be queued from the
caller and dealing with the locking complexity etc. just once.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/