linux-kernel - Re: [PATCH -next] classmate-laptop: fix for RFKILL=m, CMPC=y

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100609200218.GD2551@barata.holoscopio.com>
Date:	Wed, 9 Jun 2010 17:02:18 -0300
From:	Thadeu Lima de Souza Cascardo <cascardo@...oscopio.com>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	platform-driver-x86@...r.kernel.org,
	Matthew Garrett <mjg@...hat.com>, linux-next@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>,
	Daniel Oliveira Nascimento <don@...t.com.br>
Subject: Re: [PATCH -next] classmate-laptop: fix for RFKILL=m, CMPC=y

On Thu, Jun 03, 2010 at 09:39:03AM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@...cle.com>
> 
> Fix build error when CONFIG_RFKILL=m and CONFIG_ACPI_CMPC=y:
> classmate-laptop should depend on RFKILL or RFKILL=n.
> 
> classmate-laptop.c:(.text+0x1351fc): undefined reference to `rfkill_unregister'
> classmate-laptop.c:(.text+0x135204): undefined reference to `rfkill_destroy'
> classmate-laptop.c:(.text+0x135237): undefined reference to `rfkill_set_sw_state'
> classmate-laptop.c:(.text+0x1352b9): undefined reference to `rfkill_alloc'
> classmate-laptop.c:(.text+0x1352ca): undefined reference to `rfkill_register'
> classmate-laptop.c:(.text+0x1352d6): undefined reference to `rfkill_destroy'
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
> ---


Randy,

Since this implies a build failure, shouldn't it be sent for rc too?

Best Regards,
Cascardo.

>  drivers/platform/x86/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-next-20100603.orig/drivers/platform/x86/Kconfig
> +++ linux-next-20100603/drivers/platform/x86/Kconfig
> @@ -520,6 +520,7 @@ config TOSHIBA_BT_RFKILL
>  config ACPI_CMPC
>  	tristate "CMPC Laptop Extras"
>  	depends on X86 && ACPI
> +	depends on RFKILL || RFKILL=n
>  	select INPUT
>  	select BACKLIGHT_CLASS_DEVICE
>  	default n

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)