linux-kernel - Re: [PATCH] Marvell OpenRD-Ultimate machine support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100609204257.GJ1743@mail.wantstofly.org>
Date:	Wed, 9 Jun 2010 22:42:57 +0200
From:	Lennert Buytenhek <buytenh@...tstofly.org>
To:	Alexander Clouter <alex@...riz.org.uk>
Cc:	Dmytro Milinevskyy <milinevskyy@...il.com>,
	linux-arm-kernel@...ts.infradead.org,
	Russell King <linux@....linux.org.uk>,
	Dhaval Vasa <dhaval.vasa@...fochips.com>,
	Lennert Buytenhek <kernel@...tstofly.org>,
	Nicolas Pitre <nico@...xnic.net>,
	Simon Guinot <sguinot@...ie.com>,
	Martin Michlmayr <tbm@...ius.com>,
	Simon Kagstrom <simon.kagstrom@...insight.net>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Marvell OpenRD-Ultimate machine support

On Wed, Jun 09, 2010 at 09:39:29PM +0100, Alexander Clouter wrote:

> > >  	kirkwood_ge00_init(&openrd_ge00_data);
> > > -	if (machine_is_openrd_client())
> > > +	if (machine_is_openrd_client() ||      \__same line
> > > +		machine_is_openrd_ultimate())  /
> > >  		kirkwood_ge01_init(&openrd_ge01_data);
> > > +  <------- REMOVE
> > >  	kirkwood_sata_init(&openrd_sata_data);
> > >  	kirkwood_sdio_init(&openrd_mvsdio_data);
> > >  
> > As that 'if()' clause is still less than 77 chars wide:
> > ----
> > kirkwood_ge00_init(&openrd_ge00_data);
> > if (machine_is_openrd_client() || machine_is_openrd_ultimate())
> > 	kirkwood_ge01_init(&openrd_ge01_data);
> > kirkwood_sata_init(&openrd_sata_data);
> > kirkwood_sdio_init(&openrd_mvsdio_data);
> > ----
> 
> Better still, just make this 'if(!machine_is_openrd_base())'.

That form is more error prone when someone adds the OpenRD-SuperDuper,
though.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/