linux-kernel - Re: 2.6.35-rc2-git1 - include/linux/cgroup.h:534 invoked rcu_dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1276118458.1745.144.camel@laptop>
Date:	Wed, 09 Jun 2010 23:20:58 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Miles Lane <miles.lane@...il.com>
Cc:	paulmck@...ux.vnet.ibm.com, Vivek Goyal <vgoyal@...hat.com>,
	Eric Paris <eparis@...hat.com>,
	Lai Jiangshan <laijs@...fujitsu.com>,
	Ingo Molnar <mingo@...e.hu>,
	LKML <linux-kernel@...r.kernel.org>, nauman@...gle.com,
	eric.dumazet@...il.com, netdev@...r.kernel.org,
	Jens Axboe <jens.axboe@...cle.com>,
	Gui Jianfeng <guijianfeng@...fujitsu.com>,
	Li Zefan <lizf@...fujitsu.com>,
	Johannes Berg <johannes@...solutions.net>
Subject: Re: 2.6.35-rc2-git1 - include/linux/cgroup.h:534 invoked 
 rcu_dereference_check() without protection!

On Wed, 2010-06-09 at 17:15 -0400, Miles Lane wrote:
> On Wed, Jun 9, 2010 at 2:15 PM, Peter Zijlstra <peterz@...radead.org> wrote:
> > On Wed, 2010-06-09 at 19:57 +0200, Peter Zijlstra wrote:
> >> +       /*
> >> +        * We're not in the pid-hash yet so no cgroup attach races, and the
> >> +        * cgroup is pinned by the parent running this.
> >> +        *
> >> +        * Silence PROVE_RCU.
> >> +        */
> >
> > Hum,.. not sure that's actually true though, the parent itself is still
> > susceptible to races afaict..
> 
> Do you want what you sent earlier tested, or should I wait for another patch?

please wait, I need to sit down and sort out that code.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/