linux-kernel - Re: [PATCH 1/1] PCI: hotplug/cpqphp, fix NULL dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100609223431.GD2533@kroah.com>
Date:	Wed, 9 Jun 2010 15:34:31 -0700
From:	Greg KH <greg@...ah.com>
To:	Jiri Slaby <jslaby@...e.cz>
Cc:	jbarnes@...tuousgeek.org, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org, jirislaby@...il.com
Subject: Re: [PATCH 1/1] PCI: hotplug/cpqphp, fix NULL dereference

On Wed, Jun 09, 2010 at 10:31:13PM +0200, Jiri Slaby wrote:
> There are devices out there which are PCI Hot-plug controllers with
> compaq PCI IDs, but are not bridges, hence have pdev->subordinate
> NULL. But cpqphp expects the pointer to be non-NULL.
> 
> Add a check to the probe function to avoid oopses like:
> BUG: unable to handle kernel NULL pointer dereference at 00000050
> IP: [<f82e3c41>] cpqhpc_probe+0x951/0x1120 [cpqphp]
> *pdpt = 0000000033779001 *pde = 0000000000000000
> ...
> 
> The device here was:
> 00:0b.0 PCI Hot-plug controller [0804]: Compaq Computer Corporation PCI Hotplug Controller [0e11:a0f7] (rev 11)
> 	Subsystem: Compaq Computer Corporation Device [0e11:a2f8]
> 
> Signed-off-by: Jiri Slaby <jslaby@...e.cz>
> Cc: Greg KH <greg@...ah.com>

Acked-by: Greg Kroah-Hartman <gregkh@...e.de>

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/