linux-kernel - Re: [uml-devel] [PATCH resend] um, hweight: Fix UML boot crash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTinwQmWP-rFu9e-ns5twsZwZjuSLi5vcll55ZZhx@mail.gmail.com>
Date:	Wed, 9 Jun 2010 10:46:01 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Boaz Harrosh <bharrosh@...asas.com>
Cc:	Borislav Petkov <bp@...en8.de>, "H. Peter Anvin" <hpa@...or.com>,
	Toralf Förster <toralf.foerster@....de>,
	uml-devel <user-mode-linux-devel@...ts.sourceforge.net>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Jeff Dike <jdike@...toit.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"Rafael J. Wysocki" <rjw@...k.pl>
Subject: Re: [uml-devel] [PATCH resend] um, hweight: Fix UML boot crash

On Wed, Jun 9, 2010 at 10:09, Boaz Harrosh <bharrosh@...asas.com> wrote:
> On 06/09/2010 11:04 AM, Boaz Harrosh wrote:
>> From: Borislav Petkov <bp@...en8.de>
>>
>> Obviously UML cannot stomach callee reg-saving trickery
>> introduced with d61931d89be506372d01a90d1755f6d0a9fafe2d
>> (x86: Add optimized popcnt variants) and oopses during boot:
>> http://marc.info/?l=linux-kernel&m=127522065202435&w=2
>>
>> Redirect arch_hweight.h include from the x86 portion to the generic
>> arch_hweight.h which is a fallback to the software hweight routines.
>>
>> LKML-Reference: <201005271944.09541.toralf.foerster@....de>
>> Signed-off-by: Borislav Petkov <bp@...en8.de>

Tested-by: Geert Uytterhoeven <geert@...ux-m68k.org>

> who's going to push this ASAP. I was just (again) 3/4 through a bisect
> on 2.6.35-rc2. When I finally realized "Hey that patch, I forgot".
> (My concentration is not what it used to be)
>
> Please push this, someone

Peter, are you happy with this?
Although we still don't know why UML cannot grok it, it does fix a
regression in post-2.6.34.

>> ---
>>  arch/um/include/asm/arch_hweight.h |    6 ++++++
>>  1 files changed, 6 insertions(+), 0 deletions(-)
>>  create mode 100644 arch/um/include/asm/arch_hweight.h
>>
>> diff --git a/arch/um/include/asm/arch_hweight.h b/arch/um/include/asm/arch_hweight.h
>> new file mode 100644
>> index 0000000..c656cf4
>> --- /dev/null
>> +++ b/arch/um/include/asm/arch_hweight.h
>> @@ -0,0 +1,6 @@
>> +#ifndef _ASM_UM_HWEIGHT_H
>> +#define _ASM_UM_HWEIGHT_H
>> +
>> +#include <asm-generic/bitops/arch_hweight.h>
>> +
>> +#endif

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/