linux-kernel - Re: [PATCH -mm] only drop root anon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 10 Jun 2010 12:21:06 +0100
From:	Catalin Marinas <catalin.marinas@....com>
To:	Dave Young <hidave.darkstar@...il.com>
Cc:	Rik van Riel <riel@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-mm@...ck.org
Subject: Re: [PATCH -mm] only drop root anon_vma if not self

Dave,

On Thu, 2010-06-10 at 02:30 +0100, Dave Young wrote:
> On Thu, Jun 10, 2010 at 9:16 AM, Rik van Riel <riel@...hat.com> wrote:
> > On Wed, 9 Jun 2010 17:19:02 +0800
> > Dave Young <hidave.darkstar@...il.com> wrote:
> >
> >> > Manually bisected mm patches, the memleak caused by following patch:
> >> >
> >> > mm-extend-ksm-refcounts-to-the-anon_vma-root.patch
> >>
> >>
> >> So I guess the refcount break, either drop-without-get or over-drop
> >
> > I'm guessing I did not run the kernel with enough debug options enabled
> > when I tested my patches...
> >
> > Dave & Catalin, thank you for tracking this down.
> >
> > Dave, does the below patch fix your issue?
> 
> Yes, it fixed the issue. Thanks.

Thanks for investigating this issue.

BTW, without my kmemleak nobootmem patch (and CONFIG_NOBOOTMEM enabled),
do you get other leaks (false positives). If my patch fixes the
nobootmem problem, can I add a Tested-by: Dave Young?

Thanks.

-- 
Catalin

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/