linux-kernel - Re: [PATCH] sata_sil24: Use memory barriers before issuing commands

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C1103B1.7050307@kernel.org>
Date:	Thu, 10 Jun 2010 17:24:33 +0200
From:	Tejun Heo <tj@...nel.org>
To:	Catalin Marinas <catalin.marinas@....com>
CC:	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org,
	Colin Tuckley <colin.tuckley@....com>
Subject: Re: [PATCH] sata_sil24: Use memory barriers before issuing commands

On 06/10/2010 04:57 PM, Catalin Marinas wrote:
> The data in the cmd_block buffers may reach the main memory after the
> writel() to the device ports. This patch introduces two calls to wmb()
> to ensure the relative ordering.
> 
> Signed-off-by: Catalin Marinas <catalin.marinas@....com>
> Tested-by: Colin Tuckley <colin.tuckley@....com>
> Cc: Tejun Heo <tj@...nel.org>

Can you please add comments explaining why they're needed?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/