linux-kernel - Re: [PATCH 02/13] jump label v9: base patch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100610162247.GC19599@elte.hu>
Date:	Thu, 10 Jun 2010 18:22:47 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Jason Baron <jbaron@...hat.com>
Cc:	Frederic Weisbecker <fweisbec@...il.com>,
	linux-kernel@...r.kernel.org, mathieu.desnoyers@...ymtl.ca,
	hpa@...or.com, tglx@...utronix.de, rostedt@...dmis.org,
	andi@...stfloor.org, roland@...hat.com, rth@...hat.com,
	mhiramat@...hat.com, avi@...hat.com, davem@...emloft.net,
	vgoyal@...hat.com, sam@...nborg.org
Subject: Re: [PATCH 02/13] jump label v9: base patch


* Jason Baron <jbaron@...hat.com> wrote:

> > > +			entry = add_jump_label_entry((char *)iter_begin->name,
> > > +							count, iter_begin);
> > > +			if (IS_ERR(entry))
> > > +				return PTR_ERR(entry);
> > > +			continue;
> > > +		}
> > > +		WARN(1, KERN_ERR "build_jump_hashtable: unexpected entry!\n");
> > 
> > 
> > 
> > It seems you are going to endless loop in this fail case.
> > 
> 
> agreed. I need to stick that 'WARN' into the else clause of "if
> (!entry)" and return an error.

and make that WARN_ONCE() as well. If it ever triggers it should show up once 
and not compound the bug with spamming the console and the logs.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/